brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: better shutdown
Date Wed, 20 Jan 2016 16:14:44 GMT
GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1164

    better shutdown

    call Main.terminate() in the main thread, rather than relying on shutdown hooks
    
    fixes rest-initiated shutdown when using BrooklynJavascriptGuiLauncher
    (looks like that has been broken since #771)
    
    /cc @neykov does this look like a reasonable enhancement of your work in #771 ?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn shutdown-cleaner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1164
    
----
commit 625a732972225df94e92c25c1034ffa135062d85
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-01-20T15:56:07Z

    better shutdown
    
    call Main.terminate() in the main thread, rather than relying on shutdown hooks
    
    fixes rest-initiated shutdown when using BrooklynJavascriptGuiLauncher
    (looks like that has been broken since #771)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message