brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix the nondet cancellation test ...
Date Sat, 30 Jan 2016 09:10:28 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1179#issuecomment-177114545
  
    @ahgittin the change looks sensible, but I don't understand exactly what it's fixing.
I can see that it avoids interleaved logging from the old test's tearDown and then new test's
run.
    
        // need to await termination, otherwise interrupted-but-still-running threads 
        // may update the cancellations/messages and interfere with subsequent tests
    
    But this is in `DynamicSequentialTaskTest.tearDown`; the setUp + tearDown are marked `alwaysRun=true`;
and there's only one beforeMethod/afterMethod. Therefore subsequent tests should be using
an entirely new `BasicExecutionManager`. How could the previous test interfere with it (unless
we're doing things with statics somewhere?!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message