brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyovcheva <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Generate config/effector descript...
Date Thu, 28 Jan 2016 09:55:59 GMT
Github user iyovcheva commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1176#discussion_r51100940
  
    --- Diff: brooklyn-server/server-cli/src/main/java/org/apache/brooklyn/cli/ItemLister.java
---
    @@ -198,17 +277,36 @@ private void mkdir(String rootDir, String dirName) {
     
             protected List<URL> getUrls() throws MalformedURLException {
                 List<URL> urls = Lists.newArrayList();
    -            if (jars.isEmpty()) {
    -                String classpath = System.getenv("INITIAL_CLASSPATH");
    -                if (Strings.isNonBlank(classpath)) {
    -                    List<String> entries = Splitter.on(":").omitEmptyStrings().trimResults().splitToList(classpath);
    -                    for (String entry : entries) {
    -                        if (entry.endsWith(".jar") || entry.endsWith("/*")) {
    -                            urls.addAll(ClassFinder.toJarUrls(entry.replace("/*", "")));
    +            if (jars.isEmpty()) { //TODO: where is `jars` value write - AbstractMain.execCli(Cli<BrooklynCommand>
parser, String ...args):line 250 BrooklynCommand command = parser.parse(args)
    --- End diff --
    
    It is not allowed now to parse jars and yaml at the same time. The idea was to prevent
it and `jars` to have higher priority. Do you think it's better to throw exception after parsing
the arguments, instead of making it impossible from the code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message