brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duncangrant <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Create Password Sensor
Date Fri, 22 Jan 2016 13:25:35 GMT
Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1169#discussion_r50535789
  
    --- Diff: brooklyn-server/utils/common/src/main/java/org/apache/brooklyn/util/text/Identifiers.java
---
    @@ -18,16 +18,24 @@
      */
     package org.apache.brooklyn.util.text;
     
    +import java.security.SecureRandom;
     import java.util.Random;
     
    +import com.google.common.base.Preconditions;
    +
     public class Identifiers {
         
         private static Random random = new Random();
     
    -    /** @see #JAVA_GOOD_PACKAGE_OR_CLASS_REGEX */ 
    -    public static final String JAVA_GOOD_START_CHARS = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_";
    -    /** @see #JAVA_GOOD_PACKAGE_OR_CLASS_REGEX */ 
    -    public static final String JAVA_GOOD_NONSTART_CHARS = JAVA_GOOD_START_CHARS+"1234567890";
    +    public static final String UPPER_CASE_ALPHA = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
    +    public static final String LOWER_CASE_ALPHA = "abcdefghijklmnopqrstuvwxyz";
    +    public static final String NUMERIC = "1234567890";
    +    public static final String NON_ALPHA_NUMERIC = "!$%@#";
    --- End diff --
    
    I'd prefer to add more but went with the default set used by [lastpass](https://lastpass.com/generatepassword.php)
in case others were problematic - possibly this isn't a problem anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message