brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix race in DSTTest.testCancel
Date Fri, 22 Jan 2016 12:27:19 GMT
GitHub user ahgittin reopened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1171

    fix race in DSTTest.testCancel

    seeing errors on jenkins server though it runs fine locally;
    have patched what looks like one race, but not sure it explains the failure
    at https://builds.apache.org/job/incubator-brooklyn-pull-requests/org.apache.brooklyn$brooklyn-core/2440/testReport/junit/org.apache.brooklyn.util.core.task/DynamicSequentialTaskTest/testCancelled/
    where we are seeing an extra semaphore at the end of the test;
    have added comments and logging in case it is seen again.
    (locally all is well.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn cancel-test-race

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1171
    
----
commit cfd54d5bc5201f0d8d8cde29ac6893f5a6090947
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-01-22T09:41:00Z

    fix race in DSTTest.testCancel
    
    seeing errors on jenkins server though it runs fine locally;
    have patched what looks like one race, but not sure it explains the failure
    at https://builds.apache.org/job/incubator-brooklyn-pull-requests/org.apache.brooklyn$brooklyn-core/2440/testReport/junit/org.apache.brooklyn.util.core.task/DynamicSequentialTaskTest/testCancelled/
    where we are seeing an extra semaphore at the end of the test;
    have added comments and logging in case it is seen again.
    (locally all is well.)

commit e77f62a09cc0b256387e564862682d11c809861f
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-01-22T11:46:50Z

    also improve jmx port allocation in tests
    
    to fix another observed test failure,
    at https://builds.apache.org/job/incubator-brooklyn-pull-requests/org.apache.brooklyn$brooklyn-software-base/2439/testReport/junit/org.apache.brooklyn.feed.jmx/JmxFeedTest/setUp/
    
    Port already in use: 40125; nested exception is:
     java.net.BindException: Address already in use

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message