brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Uses externally accessible addres...
Date Fri, 22 Jan 2016 11:54:01 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-173898355
  
    @nakomis agree failure unrelated, have snuck an attempt to fix this in at #1171 btw
    
    this behaviour change seems reasonable as we normally want a load-balancer to be accessible.
 however this might not always be the case and it does set up further inconsistencies in when
`main_uri` is the subnet address vs main address.  @grkvlt in particular in clocker is this
going to cause an issue, i.e. might it combine the public IP with the private port?  /cc @aledsage

    
    we should set up some guidelines about when public v private ip's are used, and how to
configure
    
    as a quick win if we need to the `inferUrl(true/false)` call in this PR could be configurable
via a config key, e.g. `PREFER_ADVERTISING_PUBLIC_IP`.  but that feels ugly.
    
    if it doesn't cause an issue in clocker i'm happy to merge and live with inconsistency
for now, but let's be thinking about how to cleanly handle the public/private ambiguity!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message