brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Create Password Sensor
Date Fri, 22 Jan 2016 11:25:36 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-173887700
  
    looks good.  minor comments.
    
    one idea:  a yaml test would be a nice addition, esp to illustrate how it should be used
-- based e.g. on `ObjectsYamlTest` reading a simple yaml which creates a password, then the
code reads the sensor and asserts the password is non-empty and contains at least one letter
and number ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message