brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: for chained references, prefer ou...
Date Wed, 20 Jan 2016 17:16:52 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1162#discussion_r50286039
  
    --- Diff: brooklyn-server/api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -105,9 +118,19 @@ public SpecT tag(Object tag) {
     
         /** adds the given tags */
         public SpecT tags(Iterable<Object> tagsToAdd) {
    +        return tagsAdd(tagsToAdd);
    +    }
    +    /** adds the given tags */
    +    public SpecT tagsAdd(Iterable<Object> tagsToAdd) {
             Iterables.addAll(this.tags, tagsToAdd);
             return self();
         }
    +    /** replaces the given tags */
    --- End diff --
    
    Changes description to "replaces the existing tags"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message