brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Tasks cancellation
Date Wed, 20 Jan 2016 17:01:13 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/util/core/task/
    @@ -309,7 +326,7 @@ public T call() throws Exception {
                                             if (!primaryFinished && failureHandlingConfig.cancelPrimaryOnSecondaryFailure)
    -                                            cancel(true, false, false);
    +                                            cancel(TaskCancellationMode.INTERRUPT_TASK_BUT_NOT_SUBMITTED_TASKS,
    --- End diff --
    Wow, this code is winning a prize for one of the biggest indents, which is a bit of a
code smell!
    But nothing to do with this PR, so ignore here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message