brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: various fixes for start(Collectio...
Date Wed, 20 Jan 2016 07:02:19 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1161#discussion_r50220521
  
    --- Diff: brooklyn-library/software/webapp/src/main/java/org/apache/brooklyn/entity/webapp/ControlledDynamicWebAppClusterImpl.java
---
    @@ -229,7 +231,8 @@ public void start(Collection<? extends Location> locations)
{
                     }
                 }
     
    -            Entities.invokeEffectorList(this, childrenToStart, Startable.START, ImmutableMap.of("locations",
locations)).get();
    +            // don't propagate start locations
    +            Entities.invokeEffectorList(this, childrenToStart, Startable.START, ImmutableMap.of("locations",
MutableList.of())).get();
    --- End diff --
    
    Just curious, would passing an empty map instead of empty locations would be any different?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message