brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: improvements to rest-api module
Date Tue, 19 Jan 2016 14:38:17 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172872188
  
    > @JsonSerialize introduces another deps on jackson (databind) which I think it doesn't
need to be there as it really depends on the ObjectMapper settings how to ser/deser the domain
objects. In fact, ObjectMapper can deal with NON_NULL or NON_EMPTY using something like 1
    
    your link "1" is huge when i click it (maybe due to the latest push); can you be more
specific?  i have a slight pref for the current behaviour (where nulls/empties are often dropped
giving more readable JSON) and don't mind the dep on jackson, but happy to defer to you.
    
    > re HighAvailabilityMode and ManagementNodeState I thought that having a dependency
on brooklyn-api just for those enums was a bit too much, that's why I moved to brooklyn-utils-common.
    
    -1 to moving these to `brooklyn-utils-common`; that's an abuse of project structure for
visibility.  either keep the dependency on `brooklyn-api`, which seems reasonable (as it is
relatively dependency-free isn't it?) or make copies of the enums here along with tests that
assert they are real copies (with `brooklyn-api` added in test scope).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message