brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...
Date Fri, 15 Jan 2016 13:40:08 GMT
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1150#discussion_r49853491
  
    --- Diff: brooklyn-server/core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindSshMachineLocationTest.java
---
    @@ -80,5 +80,23 @@ public void testMachineUsableAfterRebind() throws Exception {
             
             assertEquals(newChildLoc.execScript(Collections.<String,Object>emptyMap(),
"mysummary", ImmutableList.of("true")), 0);
         }
    -    
    +
    +    // See https://issues.apache.org/jira/browse/BROOKLYN-215
    +    @Test(groups="Integration")
    +    public void testRebindWhenPortNull() throws Exception {
    +        SshMachineLocation machine = origManagementContext.getLocationManager().createLocation(LocationSpec.create(SshMachineLocation.class)
    +                .configure("address", "localhost")
    +                .configure("port", null));
    --- End diff --
    
    You could use SshTool.PROP_PORT.getName()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message