brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix catalog XML deserialization
Date Thu, 14 Jan 2016 16:46:20 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1147#discussion_r49750494
  
    --- Diff: brooklyn-server/core/src/test/java/org/apache/brooklyn/core/catalog/internal/CatalogDtoTest.java
---
    @@ -111,6 +113,9 @@ public CatalogDto buildExampleCatalog() {
             testEntitiesJavaCatalog.addEntry(CatalogItemBuilder.newTemplate(TestApplication.class.getCanonicalName(),
BasicBrooklynCatalog.NO_VERSION)
                     .displayName("Test App from JAR")
                     .javaType(TestApplication.class.getCanonicalName())
    +                .tag(BrooklynTags.newNotesTag("Some notes for catalog testing"))
    --- End diff --
    
    For the particular case this is fixing the deserialization will fail. But in general agree
that it would be nice to add those checks, will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message