brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support "externalised config" in ...
Date Tue, 12 Jan 2016 09:51:33 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49433075
  
    --- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -376,7 +378,7 @@ else for (String key: otherKeys) {
             catalogMetadata.remove("items");
             if (!itemDef.isEmpty()) {
                 log.debug("Reading brooklyn.catalog peer keys as item ('top-level syntax')");
    -            Map<String,?> rootItem = MutableMap.of("item", itemDef);
    +            Map<String,?> rootItem = MutableMap.of("item", (Object) itemDef);
    --- End diff --
    
    Surprised you have to cast this to an Object. But will merge as-is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message