brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyovcheva <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support "externalised config" in ...
Date Fri, 08 Jan 2016 14:09:31 GMT
Github user iyovcheva commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49190899
  
    --- Diff: brooklyn-server/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ExternalConfigYamlTest.java
---
    @@ -108,6 +110,34 @@ public void testExternalisedLocationConfigReferencedFromYaml() throws
Exception
             assertEquals(Iterables.getOnlyElement( app.getLocations() ).config().get(MY_CONFIG_KEY),
"myval");
         }
     
    +    @Test
    +    public void testExternalisedCatalogConfigReferencedFromYaml() throws Exception {
    +
    +        String yaml = Joiner.on("\n").join(
    +                "brooklyn.catalog:",
    +                "    id: osgi.test",
    +                "    itemType: template",
    +                "    version: 1.3",
    +                "    description: CentOS 6.6 With GUI - 1.3",
    +                "    displayName: CentOS 6.6",
    +                "    iconUrl: classpath:///centos.png",
    +                "    brooklyn.libraries:",
    +                "    - $brooklyn:external(\"myprovider\", \"osgikey\")",
    --- End diff --
    
    I see a problem using the name/version in test, because we need a real one that match
the url and if they are changed in future, someone would wonder why the test fails.
    
    There is one more test without external config to verify that the behaviour doesn't change
then.
    
    If you think it's not that bad to add matching for now name/version, no problem to add
them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message