brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...
Date Thu, 07 Jan 2016 15:33:43 GMT
Github user nakomis commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1129#discussion_r49084776
  
    --- Diff: brooklyn-server/software/base/src/main/java/org/apache/brooklyn/entity/software/base/SameServerDriverLifecycleEffectorTasks.java
---
    @@ -73,23 +73,17 @@ protected SameServerEntityImpl entity() {
                firewall will open the initial port instead. Mostly a problem for SameServerEntity,
localhost location.
             */
             // TODO: Remove duplication between this and SoftwareProcessImpl.getRequiredOpenPorts
    -        for (ConfigKey<?> k: entity.getEntityType().getConfigKeys()) {
    -            Object value;
    +        final Set<ConfigKey<?>> configKeys = entity.getEntityType().getConfigKeys();
    --- End diff --
    
    Minor point, but is there any reason for this to be final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message