brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graeme-Miller <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: On stop Application, unmanage loc...
Date Tue, 05 Jan 2016 09:16:08 GMT
Github user Graeme-Miller commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1124#discussion_r48825140
  
    --- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/core/entity/AbstractApplication.java
---
    @@ -220,13 +221,34 @@ public void stop() {
                     //but that could be handled by the impl at management
                     //(keeping recently unmanaged things)  
                     //  however unmanaging must be done last, _after_ we stop children and
set attributes 
    +                Location location = Iterables.getFirst(getLocations(), null);
    --- End diff --
    
    Could getLocations return an empty Collection? If so, we will use the default value of
null and throw a null pointer exception in unmanageProvisionerIfNotUsed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message