Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: johnmccabe <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1091-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1091-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: QA Updates for Clocker
Content-Type: text/plain
Message-Id: <20151207145041.ED348E0537@git1-us-west.apache.org>
Date: Mon,  7 Dec 2015 14:50:41 +0000 (UTC)

Github user johnmccabe commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1091#discussion_r46828080
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestCase.java ---
    @@ -26,5 +28,5 @@
      * @author m4rkmckenna
      */
     @ImplementedBy(value = TestCaseImpl.class)
    -public interface TestCase extends BaseTest {
    +public interface TestCase extends Entity, Startable {
    --- End diff --
    
    LGTM, shouldn't have extended BaseTest to begin with


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---