brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: reorganise project structure in p...
Date Tue, 22 Dec 2015 15:01:34 GMT
Github user geomacy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166637869
  
    I have a couple of questions - 
    
    1.  Why do we have a relativeRoot in the pom files - shouldn't we avoid  ".." in the poms
and rely on the maven repo for dependencies?   It looks particularly questionable to have
one repo (brooklyn-library) having a relative path dependency to *another repo* in its pom.
 I would recommend we remove the relativePath from all poms and ensure the maven repository
is built up in the right order.  
    1. Why for that matter do projects in brooklyn-dist and brooklyn-library have a *parent
pom* from inside brooklyn server - I would have thought that brooklyn-server would be a dependency
but not a parent?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message