brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: reorganise project structure in p...
Date Tue, 22 Dec 2015 11:35:52 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166590578
  
    awesome job.  works great so far and should really simplify the migration, as much as
we can.  great summary as well @johnmccabe.
    
    i've been through all the PR's.  here is my list of things to look at:
    
    * poms:
        * library repeats versions from software
        * test deps were commented out in many places, look like they were added but double
check
        * comment why `<relativePath/>` is used
    * jsgui
        * is it included correctly in Launcher
        * comment BrooklynJavascriptGuiLauncher.java 71 / load order
        * included correctly in release artifacts
        * comment in root / brooklyn POM about order
    * tests
        * did java-web-app-simple.yaml vanish
        * some tests are taking a long time
    * overall
        * double-check release artifacts
    
    many are just sanity checks.  i'll keep working through these.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message