brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Type registry - validation and al...
Date Thu, 17 Dec 2015 14:12:33 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-165462072
  
    @neykov All addressed.  I rebased which has lost your comments on this PR :( but they
were all good ones and you'll see my notes on email.
    
    Only thing to call out is the introduction and use of `Maybe.isNull()`.  It allows us
to speak of absent nulls which i think is a good thing.  See the creation methods on `Maybe`
for more info. /cc @aledsage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message