brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Date Thu, 17 Dec 2015 11:53:16 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1104#discussion_r47897382
  
    --- Diff: usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java
---
    @@ -710,32 +719,42 @@ private void initManagementContext() {
             }
         }
     
    -    private boolean fileExists(String file) {
    -        return new File(Os.tidyPath(file)).exists();
    +    /**
    +     * @return The canonical path of the argument.
    +     */
    +    private File resolveSymbolicLink(File f) {
    +        File f2 = f;
    +        try {
    +            f2 = f.getCanonicalFile();
    +            if (Files.isSymbolicLink(f.toPath())) {
    +                LOG.debug("Resolved symbolic link: {} -> {}", f, f2);
    +            }
    +        } catch (IOException e) {
    +            LOG.warn("Could not determine canonical name of global properties file",
e);
    --- End diff --
    
    Perhaps change log message to not say `global properties file`, as this method is more
generic (even if currently only called in that one case)?
    
    How about `Could not determine canonical path of file "+f, e`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message