brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: tryLoadClass: return optional.abs...
Date Fri, 04 Dec 2015 10:19:39 GMT
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1089#discussion_r46667152
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/classloading/JavaBrooklynClassLoadingContext.java
---
    @@ -82,6 +87,10 @@ private ClassLoader getClassLoader() {
             try {
                 className = DeserializingClassRenamesProvider.findMappedName(className);
                 return (Maybe) Maybe.of(getClassLoader().loadClass(className));
    +        } catch (NoClassDefFoundError e) {
    +            String msg = "Invalid linkage in (transitive dependencies of) class "+className+":
"+e.toString();
    +            LOG.debug(msg);
    --- End diff --
    
    As you said in the comment I prefer to be warning.
    Users are not supposed to use invalid classes in their apps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message