Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
Message-ID: <git-pr-1066-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Updates to Test framework
 asserti...
Content-Type: text/plain
Date: Tue, 24 Nov 2015 15:51:07 +0000 (UTC)

GitHub user geomacy opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1066

    Updates to Test framework assertions to support multiple assertion failures.

    At the moment in the test framework, as noted in [#1030](https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-158995925), when assertions fail it's not easy to see from the error text in the Activity log what went wrong. In particular if there are multiple assertions that failed this isn't apparent.
    
    This update merges the assertion code from SimpleShellCommand and TestFrameworkAssertions to give:
    
    - Updates test framework assertions so that multiple failures are described in the assertion failure message, such as
    ```
        Assertions failed: exit code equals 1 stdout equals bogus stdout contains porkpie
    ```
    - Supports generic 'actual' parameter, so we can avoid doing type coercions to String in
    order to check assertions.
    
    - Adds "hasTruthValue" condition.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/incubator-brooklyn update-test-assertions-for-multiple-failures

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1066
    
----
commit d3d120c5c0ed96231cbc7a4034ada8ae387cc9d1
Author: Geoff Macartney <geoff.macartney@cloudsoftcorp.com>
Date:   2015-11-24T09:05:08Z

    Updates to Test framework assertions to support multiple assertion failures.
    
    Merges the assertion code from SimpleShellCommand and TestFrameworkAssertions to give:
    
    Updates test framework assertions so that multiple failures are described
    in the assertion failure message, such as
    
        Assertions failed: exit code equals 1 stdout equals bogus stdout contains porkpie stderr
    
    Supports generic 'actual' parameter, so we can avoid doing type coercions to String in
    order to check assertions.
    
    Adds "hasTruthValue" condition.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---