Return-Path: 
 <dev-return-11398-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5196418E8E
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon,  2 Nov 2015 16:45:38 +0000 (UTC)
Received: (qmail 29859 invoked by uid 500); 2 Nov 2015 16:45:38 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 29827 invoked by uid 500); 2 Nov 2015 16:45:38 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 29816 invoked by uid 99); 2 Nov 2015 16:45:38 -0000
Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 16:45:38 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id A637B180251
	for <dev@brooklyn.apache.org>; Mon,  2 Nov 2015 16:45:37 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-east.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id yOTYDj7f5Lms for <dev@brooklyn.apache.org>;
	Mon,  2 Nov 2015 16:45:30 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 SMTP id 4082A42B7B
	for <dev@brooklyn.incubator.apache.org>;
 Mon,  2 Nov 2015 16:45:30 +0000 (UTC)
Received: (qmail 28320 invoked by uid 99); 2 Nov 2015 16:45:28 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 16:45:28 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 684022C1F6A
	for <dev@brooklyn.incubator.apache.org>;
 Mon,  2 Nov 2015 16:45:28 +0000 (UTC)
Date: Mon, 2 Nov 2015 16:45:28 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@brooklyn.incubator.apache.org
Message-ID: <JIRA.12909645.1446467429000.125807.1446482728423@Atlassian.JIRA>
In-Reply-To: <JIRA.12909645.1446467429000@Atlassian.JIRA>
References: <JIRA.12909645.1446467429000@Atlassian.JIRA>
 <JIRA.12909645.1446467429747@arcas>
Subject: [jira] [Commented] (BROOKLYN-190) Upgrade to Jetty9
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985510#comment-14985510 ] 

ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43649604
  
    --- Diff: parent/pom.xml ---
    @@ -208,9 +208,9 @@
                     <version>${swagger.version}</version>
                 </dependency>
                 <dependency>
    -                <groupId>org.eclipse.jetty.orbit</groupId>
    -                <artifactId>javax.servlet</artifactId>
    -                <version>${jetty-orbit-javax-servlet.version}</version>
    +                <groupId>javax.servlet</groupId>
    +                <artifactId>javax.servlet-api</artifactId>
    +                <version>${javax-servlet.version}</version>
    --- End diff --
    
    You left the dependency only in the `dependencyManagement` section in the parent pom, which doesn't actually pull it as a dependency, just declares which version to use in case anyone needs it. If classes from it are still directly referenced, then put it explicitly in the `dependencies` sections in modules that need it. It works now because it's a transitive dependency of jetty.


> Upgrade to Jetty9
> -----------------
>
>                 Key: BROOKLYN-190
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-190
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.8.0, 0.9.0
>            Reporter: Ciprian Ciubotariu
>            Assignee: Ciprian Ciubotariu
>            Priority: Minor
>             Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support Jetty9 (although I believe it can be used with Jetty8 as well). However, migrating Brooklyn to a more current Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)