Return-Path: 
 <dev-return-12336-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9E0B418745
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Tue, 24 Nov 2015 21:34:26 +0000 (UTC)
Received: (qmail 94463 invoked by uid 500); 24 Nov 2015 21:34:26 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 94429 invoked by uid 500); 24 Nov 2015 21:34:26 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 94412 invoked by uid 99); 24 Nov 2015 21:34:26 -0000
Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 21:34:26 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org)
 with ESMTP id 4CA871A28BB
	for <dev@brooklyn.apache.org>; Tue, 24 Nov 2015 21:34:25 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.447
X-Spam-Level: 
X-Spam-Status: No, score=0.447 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.554,
	URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-us-east.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new,
 port 10024)
	with ESMTP id rWdZe-9euLDO for <dev@brooklyn.apache.org>;
	Tue, 24 Nov 2015 21:34:15 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 SMTP id 3859E428E2
	for <dev@brooklyn.incubator.apache.org>;
 Tue, 24 Nov 2015 21:34:15 +0000 (UTC)
Received: (qmail 94336 invoked by uid 99); 24 Nov 2015 21:34:14 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 21:34:14 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AA834E01D9; Tue, 24 Nov 2015 21:34:14 +0000 (UTC)
From: CMoH <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1048-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1048-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Brooklyn OSGification -
 step 2 (b...
Content-Type: text/plain
Message-Id: <20151124213414.AA834E01D9@git1-us-west.apache.org>
Date: Tue, 24 Nov 2015 21:34:14 +0000 (UTC)

Github user CMoH commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1048#discussion_r45798003
  
    --- Diff: usage/rest-server/pom.xml ---
    @@ -241,9 +241,46 @@
                     <!-- Required to set values in build-metadata.properties -->
                     <filtering>true</filtering>
                 </resource>
    +            <resource>
    +                <directory>${basedir}/src/main/webapp</directory>
    +            </resource>
             </resources>
             <plugins>
     
    +            <plugin>
    +                <groupId>org.apache.felix</groupId>
    +                <artifactId>maven-bundle-plugin</artifactId>
    +                <extensions>true</extensions>
    +                <!-- configure plugin to generate MANIFEST.MF
    +                     adapted from http://blog.knowhowlab.org/2010/06/osgi-tutorial-from-project-structure-to.html -->
    +                <executions>
    +                    <execution>
    +                        <id>bundle-manifest</id>
    +                        <phase>process-classes</phase>
    +                        <goals>
    +                            <goal>manifest</goal>
    +                        </goals>
    +                    </execution>
    +                </executions>
    +                <configuration>
    +                    <supportedProjectTypes>
    +                        <supportedProjectType>jar</supportedProjectType>
    +                    </supportedProjectTypes>
    +                    <instructions>
    +                        <Import-Package>
    +                            com.sun.jersey.spi.container.servlet;version="[1.18.1,2.0)",
    +                            *
    +                        </Import-Package>
    +                        <Export-Package>org.apache.brooklyn.*</Export-Package>
    +                        <Implementation-SHA-1>${buildNumber}</Implementation-SHA-1>
    +                        <Implementation-Branch>${scmBranch}</Implementation-Branch>
    --- End diff --
    
    Yes, they are indeed. However, I plan to revisit each pom regarding maven-bundle-plugin, so I slacked a bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---