Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1048-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1048-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Brooklyn OSGification -
 step 2 (b...
Content-Type: text/plain
Message-Id: <20151124200551.CFD58E009E@git1-us-west.apache.org>
Date: Tue, 24 Nov 2015 20:05:51 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1048#discussion_r45787300
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/Osgis.java ---
    @@ -338,12 +336,12 @@ public static Framework getFramework(String felixCacheDir, boolean clean) {
          * @param framework
          */
         public static void ungetFramework(Framework framework) {
    -        final Bundle frameworkBundle = FrameworkUtil.getBundle(Framework.class);
    -        if (frameworkBundle != null) {
    -            // already running inside an OSGi container
    -            final BundleContext ctx = frameworkBundle.getBundleContext();
    -            final ServiceReference<?> ref = ctx.getServiceReference(Framework.class);
    -            ctx.ungetService(ref);
    +        final Bundle bundle = FrameworkUtil.getBundle(Osgis.class);
    +        if (bundle != null) {
    +//            // already running inside an OSGi container
    +//            final BundleContext ctx = bundle.getBundleContext();
    +//            final ServiceReference<Framework> ref = ctx.getServiceReference(Framework.class);
    +//            ctx.ungetService(ref);
    --- End diff --
    
    Do you need this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---