Return-Path: 
 <dev-return-12300-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A130E181EA
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Tue, 24 Nov 2015 17:14:00 +0000 (UTC)
Received: (qmail 80302 invoked by uid 500); 24 Nov 2015 17:14:00 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 80263 invoked by uid 500); 24 Nov 2015 17:14:00 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 80252 invoked by uid 99); 24 Nov 2015 17:14:00 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 17:14:00 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id DA68FC5948
	for <dev@brooklyn.apache.org>; Tue, 24 Nov 2015 17:13:59 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.419
X-Spam-Level: 
X-Spam-Status: No, score=0.419 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.562, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-east.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id SvYDxYpJ04iq for <dev@brooklyn.apache.org>;
	Tue, 24 Nov 2015 17:13:52 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 SMTP id 6E29042AEE
	for <dev@brooklyn.incubator.apache.org>;
 Tue, 24 Nov 2015 17:13:52 +0000 (UTC)
Received: (qmail 80230 invoked by uid 99); 24 Nov 2015 17:13:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 17:13:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id C2E03E02D3; Tue, 24 Nov 2015 17:13:51 +0000 (UTC)
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1037-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1037-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Add quorum check enricher
 and agg...
Content-Type: text/plain
Message-Id: <20151124171351.C2E03E02D3@git1-us-west.apache.org>
Date: Tue, 24 Nov 2015 17:13:51 +0000 (UTC)

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1037#discussion_r45765140
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -891,6 +892,39 @@ protected static int count(Iterable<? extends Object> vals, boolean includeNullV
             return result;
         }
         
    +    @Beta
    +    public static class ComputingIsQuorate<T extends Object> implements Function<Collection<T>, T> {
    --- End diff --
    
    I can't escape the generics either. However, I can cast `ComputingIsQuorate` to `(Function<? super Collection<?>, ?>)` in Aggregator! Personally I prefer keeping ComputingIsQuorate simple and the ugliness in `lookupTransformation`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---