Return-Path: 
 <dev-return-12219-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 39B2518DB3
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon, 23 Nov 2015 21:21:41 +0000 (UTC)
Received: (qmail 87191 invoked by uid 500); 23 Nov 2015 21:21:41 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 87161 invoked by uid 500); 23 Nov 2015 21:21:41 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 87141 invoked by uid 99); 23 Nov 2015 21:21:40 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 21:21:40 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id 4BD9BC25CF
	for <dev@brooklyn.apache.org>; Mon, 23 Nov 2015 21:21:40 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.393
X-Spam-Level: 
X-Spam-Status: No, score=0.393 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.588, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id c4vJCBacdgbz for <dev@brooklyn.apache.org>;
	Mon, 23 Nov 2015 21:21:35 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 0B98020C41
	for <dev@brooklyn.incubator.apache.org>;
 Mon, 23 Nov 2015 21:21:34 +0000 (UTC)
Received: (qmail 87098 invoked by uid 99); 23 Nov 2015 21:21:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 21:21:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id BEBBDE0A36; Mon, 23 Nov 2015 21:21:34 +0000 (UTC)
From: mikezaccardo <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1037-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1037-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Add quorum check enricher
 and agg...
Content-Type: text/plain
Message-Id: <20151123212134.BEBBDE0A36@git1-us-west.apache.org>
Date: Mon, 23 Nov 2015 21:21:34 +0000 (UTC)

Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1037#discussion_r45662431
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -891,6 +892,39 @@ protected static int count(Iterable<? extends Object> vals, boolean includeNullV
             return result;
         }
         
    +    @Beta
    +    public static class ComputingIsQuorate<T extends Object> implements Function<Collection<T>, T> {
    --- End diff --
    
    Changing this definition to `public static class ComputingIsQuorate implements Function<Collection<Boolean>, Boolean>` is certainly sensible.
    
    However, doing this causes problems in `Aggregator`.  The return value must ultimately be assigned to `Function<? super Collection<T>, ? extends U> transformation` but I cannot seem to escape compile errors when attempting to cast / assign the value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---