Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1039-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1039-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Adds support for interfaces
 tag o...
Content-Type: text/plain
Message-Id: <20151118161617.94D1EDFBD6@git1-us-west.apache.org>
Date: Wed, 18 Nov 2015 16:16:17 +0000 (UTC)

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1039#discussion_r45220331
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
    @@ -51,9 +54,35 @@ public String getContents() {
                 return contents;
             }
         }
    +
    +    public static class InterfacesTag {
    +        @JsonProperty
    +        final List<Class<?>> interfaces;
    +
    +        public InterfacesTag(List<Class<?>> interfaces) {
    +            this.interfaces = interfaces;
    +        }
    +
    +        public List<Class<?>> getInterfaces() {
    +            return interfaces;
    +        }
    +
    +        @Override
    +        public boolean equals(Object obj) {
    +            return EqualsBuilder.reflectionEquals(this, obj);
    --- End diff --
    
    Surely this is overkill for what can be just written as ~ `obj == this || (obj.getClass().equals(getClass()) && InterfacesTag.class.cast(obj).interfaces.equals(this.interfaces))`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---