Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1020-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1020-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Add TOSCA metadata support
 for ca...
Content-Type: text/plain
Message-Id: <20151117172101.46648E0329@git1-us-west.apache.org>
Date: Tue, 17 Nov 2015 17:21:01 +0000 (UTC)

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1020#issuecomment-157442362
  
    Great ideas.  I like the idea of using (and introducing if needed) some general purpose interfaces like `HasDatastoreUrl` as markers to map this to a TOSCA type hierarchy.
    
    Yes, add the `tag()` methods for `CatalogItem`; this is useful.  Include some tests please.  (And probably close this PR.)
    
    Probably worth some discussion on list about how to expose supertypes.  Adding dozens of tags to support all interfaces is not very nice; probably it is just some which we care about.  Also as it happens in #1017 I'm working on a `TypeRegistry` to replace the catalog, and supertypes is one of the things I'm adding to the `RegisteredType` which will replace `CatalogItem`.  Maybe you can look at that and help move that ball down the field.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---