Return-Path: 
 <dev-return-11698-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 33FCA18EA7
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Thu, 12 Nov 2015 14:58:35 +0000 (UTC)
Received: (qmail 89373 invoked by uid 500); 12 Nov 2015 14:58:35 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 89340 invoked by uid 500); 12 Nov 2015 14:58:35 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 89329 invoked by uid 99); 12 Nov 2015 14:58:34 -0000
Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 14:58:34 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id 56583C0481
	for <dev@brooklyn.apache.org>; Thu, 12 Nov 2015 14:58:34 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id vl-eHUC7ObEO for <dev@brooklyn.apache.org>;
	Thu, 12 Nov 2015 14:58:24 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 371B120384
	for <dev@brooklyn.incubator.apache.org>;
 Thu, 12 Nov 2015 14:58:24 +0000 (UTC)
Received: (qmail 88540 invoked by uid 99); 12 Nov 2015 14:58:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 14:58:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id E0D8CE56F1; Thu, 12 Nov 2015 14:58:23 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1017-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1017-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Flesh out type creation
 using the...
Content-Type: text/plain
Message-Id: <20151112145823.E0D8CE56F1@git1-us-west.apache.org>
Date: Thu, 12 Nov 2015 14:58:23 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44665943
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypes.java ---
    @@ -66,180 +94,131 @@ public static RegisteredType of(CatalogItem<?, ?> item) {
             type.deprecated = item.isDeprecated();
     
             // TODO
    -        // javaType, specType, registeredTypeName ...
    -        // tags ?
    +        // probably not: javaType, specType, registeredTypeName ...
    +        // maybe: tags ?
             return type;
         }
     
    -    /** Visitor adapter which can be used to ensure all kinds are supported */
    -    public static abstract class RegisteredTypeKindVisitor<T> {
    -        public T visit(RegisteredType type) {
    -            if (type==null) throw new NullPointerException("Registered type must not be null");
    -            if (type instanceof RegisteredSpecType) {
    -                return visitSpec((RegisteredSpecType)type);
    -            }
    -            // others go here
    -            throw new IllegalStateException("Unexpected registered type: "+type.getClass());
    -        }
    -
    -        protected abstract T visitSpec(RegisteredSpecType type);
    -        
    -        // TODO beans, others
    +    /** Preferred mechanism for defining a bean {@link RegisteredType} */
    +    public static RegisteredType bean(String symbolicName, String version, TypeImplementationPlan plan, @Nullable Class<?> superType) {
    +        return addSuperType(new BasicRegisteredType(RegisteredTypeKind.BEAN, symbolicName, version, plan), superType);
         }
         
    -    public static RegisteredTypeKind getKindOf(RegisteredType type) {
    -        return new RegisteredTypeKindVisitor<RegisteredTypeKind>() {
    -            @Override protected RegisteredTypeKind visitSpec(RegisteredSpecType type) { return RegisteredTypeKind.SPEC; }
    -        }.visit(type);
    +    public static RegisteredType spec(String symbolicName, String version, TypeImplementationPlan plan, @Nullable Class<?> superType) {
    --- End diff --
    
    `symbolicName`, `version` are `@Nullable` as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---