Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-1017-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-1017-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Flesh out type creation
 using the...
Content-Type: text/plain
Message-Id: <20151112111135.CAF6BE0099@git1-us-west.apache.org>
Date: Thu, 12 Nov 2015 11:11:35 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44645535
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/TypePlanTransformers.java ---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.typereg;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.ServiceLoader;
    +import java.util.TreeMap;
    +
    +import org.apache.brooklyn.api.mgmt.ManagementContext;
    +import org.apache.brooklyn.api.typereg.BrooklynTypeRegistry;
    +import org.apache.brooklyn.api.typereg.RegisteredType;
    +import org.apache.brooklyn.api.typereg.RegisteredTypeLoadingContext;
    +import org.apache.brooklyn.util.collections.MutableList;
    +import org.apache.brooklyn.util.exceptions.Exceptions;
    +import org.apache.brooklyn.util.exceptions.PropagatedRuntimeException;
    +import org.apache.brooklyn.util.guava.Maybe;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.annotations.Beta;
    +import com.google.common.annotations.VisibleForTesting;
    +import com.google.common.collect.ArrayListMultimap;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Iterables;
    +import com.google.common.collect.Multimap;
    +
    +public class TypePlanTransformers {
    +
    +    private static final Logger log = LoggerFactory.getLogger(TypePlanTransformers.class);
    +
    +    private static Collection<BrooklynTypePlanTransformer> getAll() {
    +        return ImmutableList.copyOf(ServiceLoader.load(BrooklynTypePlanTransformer.class));
    +    }
    +
    +    private static Collection<Class<? extends BrooklynTypePlanTransformer>> OVERRIDE;
    +    @SafeVarargs
    +    @VisibleForTesting
    +    public synchronized static void forceAvailable(Class<? extends BrooklynTypePlanTransformer> ...classes) {
    +        OVERRIDE = Arrays.asList(classes);
    +    }
    +    public synchronized static void clearForced() {
    +        OVERRIDE = null;
    +    }
    +
    +    public static Collection<BrooklynTypePlanTransformer> all(ManagementContext mgmt) {
    +        // TODO cache these in the TypeRegistry, looking for new ones periodically or supplying a way to register them
    +        Collection<Class<? extends BrooklynTypePlanTransformer>> override = OVERRIDE;
    +        Collection<BrooklynTypePlanTransformer> result = new ArrayList<BrooklynTypePlanTransformer>();
    +        if (override!=null) {
    +            for (Class<? extends BrooklynTypePlanTransformer> o1: override) {
    +                try {
    +                    result.add(o1.newInstance());
    +                } catch (Exception e) {
    +                    Exceptions.propagate(e);
    +                }
    +            }
    +        } else {
    +            result.addAll(getAll());
    +        }
    +        for(BrooklynTypePlanTransformer t : result) {
    +            t.injectManagementContext(mgmt);
    +        }
    +        return result;
    +    }
    +
    +    /** returns a list of {@link BrooklynTypePlanTransformer} instances for this {@link ManagementContext}
    +     * which may be able to handle the given plan; the list is sorted with highest-score transformer first */
    +    @Beta
    +    public static List<BrooklynTypePlanTransformer> forType(ManagementContext mgmt, RegisteredType type, RegisteredTypeLoadingContext constraint) {
    +        Multimap<Double,BrooklynTypePlanTransformer> byScoreMulti = ArrayListMultimap.create(); 
    +        Collection<BrooklynTypePlanTransformer> transformers = all(mgmt);
    +        for (BrooklynTypePlanTransformer transformer : transformers) {
    +            double score = transformer.scoreForType(type, constraint);
    +            if (score>0) byScoreMulti.put(score, transformer);
    +        }
    +        Map<Double, Collection<BrooklynTypePlanTransformer>> tree = new TreeMap<Double, Collection<BrooklynTypePlanTransformer>>(byScoreMulti.asMap());
    +        List<Collection<BrooklynTypePlanTransformer>> highestFirst = new ArrayList<Collection<BrooklynTypePlanTransformer>>(tree.values());
    +        Collections.reverse(highestFirst);
    --- End diff --
    
    Could pass `Collections.reverseOrder()` to the `TreeMap` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---