Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2C5818549 for ; Wed, 11 Nov 2015 13:03:24 +0000 (UTC) Received: (qmail 10326 invoked by uid 500); 11 Nov 2015 13:03:24 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 10286 invoked by uid 500); 11 Nov 2015 13:03:23 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 10198 invoked by uid 99); 11 Nov 2015 13:03:22 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 13:03:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 860E11A2CBE for ; Wed, 11 Nov 2015 13:03:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fUMdv_eKIiHn for ; Wed, 11 Nov 2015 13:03:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 6D8A1439DB for ; Wed, 11 Nov 2015 13:03:14 +0000 (UTC) Received: (qmail 10137 invoked by uid 99); 11 Nov 2015 13:03:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 13:03:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A9C67E0A23; Wed, 11 Nov 2015 13:03:13 +0000 (UTC) From: neykov To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Add ManagementContext.getConfigWi... Content-Type: text/plain Message-Id: <20151111130313.A9C67E0A23@git1-us-west.apache.org> Date: Wed, 11 Nov 2015 13:03:13 +0000 (UTC) Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1018#issuecomment-155780641 So we need to resolve external values at `getConfig` time, but at the same time allow mutations of the properties. What if you patch the config in the `AbstractManagementContext` constructor, but lazily - here's what I mean. In the constructor wrap the properties in a delegate, including a reference to the mgmt context. On `get`s check the value and if needed resolve. Alternatively convert any external values to suppliers, resolving on `get` (i.e. make `BrooklynProperties` handle suppliers). It's obviously hackish to mutate the `ManagementContext.getConfig()` - might be a good reason to find a generic way to do it, but out of scope for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---