Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB76D183F9 for ; Thu, 5 Nov 2015 14:27:41 +0000 (UTC) Received: (qmail 67962 invoked by uid 500); 5 Nov 2015 14:27:41 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 67931 invoked by uid 500); 5 Nov 2015 14:27:41 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 67920 invoked by uid 99); 5 Nov 2015 14:27:41 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2015 14:27:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F1C3FCC023 for ; Thu, 5 Nov 2015 14:27:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iyBSxeip1OU9 for ; Thu, 5 Nov 2015 14:27:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id B86D144502 for ; Thu, 5 Nov 2015 14:27:31 +0000 (UTC) Received: (qmail 67878 invoked by uid 99); 5 Nov 2015 14:27:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2015 14:27:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 33562E390A; Thu, 5 Nov 2015 14:27:31 +0000 (UTC) From: geomacy To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Add EntityAsserts and HttpUtils. Content-Type: text/plain Message-Id: <20151105142731.33562E390A@git1-us-west.apache.org> Date: Thu, 5 Nov 2015 14:27:31 +0000 (UTC) Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-154074295 The sleeps are there to allow the test HTTP server time to shut down. That's not required in all tests, so I could speed things up a bit by changing the test condition, but it is needed in some cases (for the 'eventually becomes unavailable' type tests). I could add a timeout to the shutdown, but it occurs to me that it might be better to mark these as integration tests, because - (a) they are not going to run any faster (they already take , and - (b) the code under test is fairly 'low level' and not likely to break because of other code within Brooklyn changing so it may not add a lot of value to run these tests on every build, and it will slow things down a bit. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---