Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-997-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-997-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: [BROOKLYN-190] Move from
 Jetty8 t...
Content-Type: text/plain
Message-Id: <20151102144904.04805E0418@git1-us-west.apache.org>
Date: Mon,  2 Nov 2015 14:49:04 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43634926
  
    --- Diff: usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
    @@ -379,13 +381,25 @@ public synchronized void start() throws Exception {
                     throw new IllegalStateException("Unable to provision port for web console (wanted "+portRange+")");
             }
     
    -        server = new Server();
    -        final Connector connector;
    +
    +        // use a nice name in the thread pool (otherwise this is exactly the same as Server defaults)
    +        QueuedThreadPool threadPool = new QueuedThreadPool();
    +        threadPool.setName("brooklyn-jetty-server-"+actualPort+"-"+threadPool.getName());
    +
    +        server = new Server(threadPool);
    +        final ServerConnector connector;
    +
             if (getHttpsEnabled()) {
    -            connector = new SslSelectChannelConnector(createContextFactory());
    +            HttpConfiguration sslHttpConfig = new HttpConfiguration();
    +            sslHttpConfig.setSecureScheme("https");
    +            sslHttpConfig.setSecurePort(actualPort);
    +
    +            SslContextFactory sslContextFactory = createContextFactory();
    +            connector = new ServerConnector(server, new SslConnectionFactory(sslContextFactory, "http/1.1"), new HttpConnectionFactory(sslHttpConfig));
    --- End diff --
    
    Use HttpVersion.HTTP_1_1.asString().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---