brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Date Tue, 24 Nov 2015 19:58:33 GMT
GitHub user m4rkmckenna opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1068

    Reverting changes made in #1060 and fixed root cause

    I incorrectly diagnosed the issue in #1060 ... so changes made reverted
    
    Root cause was due to Swagger updates made in #1040 
    `@ApiOperation()` annotation on `CatalogApi#create` had response type set to `javax.ws.rs.core.Response`
causing the BrooklynApi to try and marshall the returned entity to that type
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/m4rkmckenna/incubator-brooklyn bugfix/brooklyn-api-parse-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1068.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1068
    
----
commit fd786359a4a2a1468ac9e981cb4a7c1d46803840
Author: Mark McKenna <m4rkmckenna@gmail.com>
Date:   2015-11-24T19:35:20Z

    Reverting incorrect diagnosis for Parse Exception (#1060)

commit ac16772de588a013fb15e077dd685643980125f9
Author: Mark McKenna <m4rkmckenna@gmail.com>
Date:   2015-11-24T19:40:20Z

    Set ApiOperaion response class to String
    
     Reason :: Using javax.ws.rs.core.Response is invalid

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message