brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Adds WinRmTool interface
Date Wed, 18 Nov 2015 22:08:59 GMT
GitHub user aledsage opened a pull request:

    Adds WinRmTool interface

    We want the interface/class within Brooklyn so that the rest of the code doesn't depend
on winrm4j directly.
    We also want to be able to swap out the Winrm4jTool for an alternative implementation,
just through configuration.
    Note that the unqualified interface name / class name are the same as the names in `io.cloudsoft.winrm4j.winrm.WinRmTool`
and ` io.cloudsoft.winrm4j.winrm.WinRmToolResponse`. Is that a good idea? Any better suggestions
for names?

You can merge this pull request into a Git repository by running:

    $ git pull refactor/WinRmTool-interface

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1045
commit 42c1113258bb66ba98c7fcde6c304dad4faed38c
Author: Aled Sage <>
Date:   2015-11-18T15:33:07Z

    Adds WinRmTool interface

commit f8c7673604ebc572f3eb3bb01d0dfe53a954c8e6
Author: Aled Sage <>
Date:   2015-11-18T15:33:22Z

    Fix javadoc typo in SshTool


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message