brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdowner <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add ManagementContext.getConfigWi...
Date Tue, 10 Nov 2015 16:05:45 GMT
GitHub user rdowner opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1018

    Add ManagementContext.getConfigWithExternalConfigResolved()

    I'm not really sure about this. Throwing it out there to see what people think.
    
    The external configuration supplier feature is great, but it doesn't work with site-wide
configuration defined in brooklyn.properties. This PR is an attempt to add this function.
    
    It, unfortunately, is not a simple matter. Because external configuration is *defined*
in brooklyn.properties, there's a possible recursion problem. We could resolve this during
initialisation of the management context, but we want to keep the behaviour that the configuration
suppliers are invoked whenever required and always return fresh values, rather than resolving
them at startup and leaving them to go stale. Some of my attempted solutions exposed weird
bugs.
    
    So the simplest possible thing is to not attempt to retro-fit this but instead add a new
method which explicitly retrieves the brooklyn.properties values, with configuration resolved
there and then.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdowner/incubator-brooklyn brooklyn-properties-external-config

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1018
    
----
commit e5fe7a3acce158fbd9b0cf97e69b5c7a1f779a04
Author: Richard Downer <richard@apache.org>
Date:   2015-11-10T15:51:15Z

    Add ManagementContext.getConfigWithExternalConfigResolved()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message