brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Unwrap camp plan with parent over...
Date Fri, 06 Nov 2015 16:49:45 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1007

    Unwrap camp plan with parent overriding child displayName

    There's an unexpected side effect presently where pointing to a catalog item and giving
a top-level name to the plan will prevent unwrapping. It's surprising to users and even more
so because it wasn't the case a few months ago.
    
    For example the following catalog item:
    
    ```
    brooklyn.catalog:
      id: simpleApp
      version: 1.0
      displayName: Simple App
      itemType: template
      item:
        services:
        - type: my-simple-app
    ```
    
    when started in the Application Wizard and given a name, equivalent to the following plan:
    
    ```
    name: My App
    services:
      - type: "simpleApp:1.0"
    ```
    
    will result in this hierarchy:
    
    ```
    * My App (BasicApplication)
        * Simple App (my-simple-app)
    ```
    
    I propose that we change the logic such that the root level name will overwrite the child's
name, so the hierarchy becomes:
    
    ```
    * My App (my-simple-app)
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn unwrap-display-name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1007
    
----
commit 564586b45ef61809df1bfdac9140d97819df6eb8
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2015-11-06T16:48:05Z

    Unwrap camp plan with parent overriding child displayName
    
    Don't prevent unwrapping in case displayName is different, override the child's name instead

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message