brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-190) Upgrade to Jetty9
Date Thu, 05 Nov 2015 17:50:27 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992095#comment-14992095
] 

ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r44043852
  
    --- Diff: usage/launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynWebServerTest.java
---
    @@ -150,10 +151,9 @@ public void verifyHttpsCiphers() throws Exception {
             brooklynProperties.put(BrooklynWebConfig.TRANSPORT_CIPHERS, "XXX");
             try {
                 verifyHttpsFromConfig(brooklynProperties);
    -            fail("Expected to fail due to unsupported ciphers during connection negotiation");
    +            fail("Expected to fail due to to unsupported ciphers during connection negotiation");
    --- End diff --
    
    An extra `to`.
    
    @CMoH, checked out the branch and built locally - the test is failing for me, no `SocketException`
in the stack trace. Here's my stack trace.
    
    ```
    2015-11-05 19:45:30,286 WARN  Exception while notifying connection SslConnection@7df01c0f{NEED_WRAP,eio=-1/-1,di=-1}
-> HttpConnection@42dad75{IDLE}
    org.eclipse.jetty.io.RuntimeIOException: javax.net.ssl.SSLHandshakeException: No appropriate
protocol (protocol is disabled or cipher suites are inappropriate)
    	at org.eclipse.jetty.io.ssl.SslConnection.onOpen(SslConnection.java:150) ~[jetty-io-9.2.13.v20150730.jar:9.2.13.v20150730]
    Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled
or cipher suites are inappropriate)
    	at sun.security.ssl.Handshaker.activate(Handshaker.java:470) ~[na:1.7.0_80]
    FAILED: verifyHttpsCiphers
    org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: javax.net.ssl.SSLHandshakeException:
Remote host closed connection during handshake
    	at org.apache.brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:103)
    	at org.apache.brooklyn.util.core.http.HttpTool.execAndConsume(HttpTool.java:364)
    	at org.apache.brooklyn.launcher.BrooklynWebServerTest.verifyHttpsFromConfig(BrooklynWebServerTest.java:171)
    	at org.apache.brooklyn.launcher.BrooklynWebServerTest.verifyHttpsCiphers(BrooklynWebServerTest.java:153)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
    	at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
    	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
    	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
    	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
    	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
    	at org.testng.TestRunner.privateRun(TestRunner.java:767)
    	at org.testng.TestRunner.run(TestRunner.java:617)
    	at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
    	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
    	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
    	at org.testng.SuiteRunner.run(SuiteRunner.java:254)
    	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
    	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
    	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
    	at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
    	at org.testng.TestNG.run(TestNG.java:1057)
    	at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:115)
    	at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:207)
    	at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:178)
    Caused by: javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake
    	at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:953)
    	at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1332)
    	at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1359)
    	at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1343)
    	at org.apache.http.conn.ssl.SSLSocketFactory.connectSocket(SSLSocketFactory.java:543)
    	at org.apache.http.conn.ssl.SSLSocketFactory.connectSocket(SSLSocketFactory.java:409)
    	at org.apache.http.impl.conn.DefaultClientConnectionOperator.openConnection(DefaultClientConnectionOperator.java:177)
    	at org.apache.http.impl.conn.ManagedClientConnectionImpl.open(ManagedClientConnectionImpl.java:304)
    	at org.apache.http.impl.client.DefaultRequestDirector.tryConnect(DefaultRequestDirector.java:611)
    	at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:446)
    	at org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:882)
    	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
    	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107)
    	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55)
    	at org.apache.brooklyn.util.core.http.HttpTool.execAndConsume(HttpTool.java:356)
    	... 26 more
    Caused by: java.io.EOFException: SSL peer shut down incorrectly
    	at sun.security.ssl.InputRecord.read(InputRecord.java:482)
    	at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:934)
    	... 40 more
    ```
    
    The original test is working fine (though I suspect the exception list is too generous
- will address in a separate PR).


> Upgrade to Jetty9
> -----------------
>
>                 Key: BROOKLYN-190
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-190
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.8.0, 0.9.0
>            Reporter: Ciprian Ciubotariu
>            Assignee: Ciprian Ciubotariu
>            Priority: Minor
>             Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support Jetty9 (although
I believe it can be used with Jetty8 as well). However, migrating Brooklyn to a more current
Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message