brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-190) Upgrade to Jetty9
Date Mon, 02 Nov 2015 14:48:27 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985313#comment-14985313
] 

ASF GitHub Bot commented on BROOKLYN-190:
-----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43634842
  
    --- Diff: camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/rest/CampServer.java
---
    @@ -118,7 +120,12 @@ public synchronized void stop() {
         
         public Integer getPort() {
             if (server==null) return null;
    -        return server.getConnectors()[0].getLocalPort();
    +        try {
    +            NetworkConnector networkConnector = (NetworkConnector) server.getConnectors()[0];
    +            return networkConnector.getLocalPort();
    +        } catch (ClassCastException ex) {
    +            return null;
    --- End diff --
    
    Don't get this, why explicitly catch this exception? Lots of other places where the same
cast is done, so no point really.


> Upgrade to Jetty9
> -----------------
>
>                 Key: BROOKLYN-190
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-190
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.8.0, 0.9.0
>            Reporter: Ciprian Ciubotariu
>            Assignee: Ciprian Ciubotariu
>            Priority: Minor
>             Fix For: 0.9.0
>
>
> According to [1] jetty9 is now the stable version.
> In relation to BROOKLYN-183, current stable pax-web 4.x series also support Jetty9 (although
I believe it can be used with Jetty8 as well). However, migrating Brooklyn to a more current
Jetty version seems preferable.
> [1] http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message