brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Updates to Test framework asserti...
Date Mon, 30 Nov 2015 17:13:15 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r46172328
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTest.java
---
    @@ -36,27 +40,10 @@
     @ImplementedBy(SimpleShellCommandTestImpl.class)
     public interface SimpleShellCommandTest extends BaseTest {
     
    -    String TMP_DEFAULT = "/tmp";
    -
    -    /**
    -     * Equals assertion on command result.
    -     */
    -    String EQUALS = "equals";
    -
         /**
    -     * String contains assertion on command result.
    +     * Default location for temporary files.
          */
    -    String CONTAINS = "contains";
    -
    -    /**
    -     * Regex match assertion on command result.
    -     */
    -    String MATCHES = "matches";
    -
    -    /**
    -     * Is-empty match assertion on command result.
    -     */
    -    String IS_EMPTY = "isEmpty";
    +    String TMP_DEFAULT = "/tmp";
    --- End diff --
    
    Actually, I misread the context - this is in main rather than test. But it's the path
on the *target* machine rather than the Brooklyn machine, so using `/tmp` is right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message