brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya...
Date Fri, 27 Nov 2015 10:15:34 GMT
Github user ahgittin commented on the pull request:
    the following issues are still outstanding:
    * check/fix `overflow-x: scroll` for textareas, likely others depend on this style you've
removed --
    * 3rd party deps into `libs/` like the others, not in `lib/` and `addons/` (or say why
    * revert auto-scanning of classpath for REST API; it significantly increases startup time
and typically we don't want it (you can trigger a scan by POSTing a suitable if
you need to, or add those explicit items you wish to have); if you think it should be there,
please give more details --
    new ones:
    * UI does not run:  `:8081/assets/js/router.js:39 Uncaught TypeError: serverStatus.addCallback
is not a function` (and we get the same error with JS jasmine tests: `[ERROR] java.lang.RuntimeException:
org.openqa.selenium.WebDriverException: com.gargoylesoftware.htmlunit.ScriptException: Wrapped
com.gargoylesoftware.htmlunit.ScriptException: Wrapped com.gargoylesoftware.htmlunit.ScriptException:
TypeError: Cannot find function addCallback in object [object Object]. (http://localhost:57004/src/js/router.js#39)`)
    * license metadata needs to be added to `overrides.yaml` (the `LICENSE` files are autogenerated
from this) -
    ability to test is limited by the above issues!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message