brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Updates to Test framework asserti...
Date Wed, 25 Nov 2015 10:17:16 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45849884
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTest.java
---
    @@ -87,21 +90,24 @@
          * If not explicitly configured, the default assertion is a non-zero exit code.
          */
         @SetFromFlag("assertStatus")
    -    ConfigKey<Map> ASSERT_STATUS = ConfigKeys.newConfigKey(Map.class, "assert.status",
    -            "Assertions on command exit code", Maps.newLinkedHashMap());
    +    ConfigKey<List<Map<String, Object>>> ASSERT_STATUS = ConfigKeys.newConfigKey(
    --- End diff --
    
    sadly you can't do `ConfigKey<Map | List>` :) so the way is just `ConfigKey<Object>`
and use a static method to coerce the result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message