brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Updates to Test framework asserti...
Date Wed, 25 Nov 2015 09:32:23 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45845108
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCallImpl.java
---
    @@ -66,31 +68,35 @@ public void start(Collection<? extends Location> locations)
{
             }
         }
     
    -    private Supplier<String> buildDataSupplier(final HttpAssertionTarget httpAssertionTarget,
final String url) {
    -
    -        switch (httpAssertionTarget) {
    +    private void doRequestAndCheckAssertions(Map<String, Duration> flags, List<Map<String,
Object>> assertions,
    +                                             HttpAssertionTarget target, final String
url) {
    +        switch (target) {
                 case body:
    -                return new Supplier<String>() {
    +                Supplier<String> getBody = new Supplier<String>() {
    --- End diff --
    
    Thanks, those are good to know, especially about the risk of the anonymous classes getting
into persistence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message