brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Updates to Test framework asserti...
Date Wed, 25 Nov 2015 09:04:34 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45842311
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTest.java
---
    @@ -87,21 +90,24 @@
          * If not explicitly configured, the default assertion is a non-zero exit code.
          */
         @SetFromFlag("assertStatus")
    -    ConfigKey<Map> ASSERT_STATUS = ConfigKeys.newConfigKey(Map.class, "assert.status",
    -            "Assertions on command exit code", Maps.newLinkedHashMap());
    +    ConfigKey<List<Map<String, Object>>> ASSERT_STATUS = ConfigKeys.newConfigKey(
    --- End diff --
    
    do the old tests still work?  and do we want to be this strict or make best effort to
understand -- e.g. if this is `ConfigKey<Object>` we can have a method e.g. `getAssertions(ASSERT_STATUS)`
which retrieves it and creates a list of maps, but which would be more forgiving, e.g. if
it's a single map we could wrap it in a list.
    
    this is new so i don't mind either way.  i prefer making best-efforts to parse people's
intentions and warning but still working if they're wrong (especially if we're changing a
syntax which people are already using, as we are here).  however other people in the community
prefer fail fast even on user input so either is fine...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message