brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 2 (b...
Date Tue, 24 Nov 2015 20:02:58 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1048#discussion_r45786901
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicConfigurableObject.java
---
    @@ -53,7 +53,7 @@ public BasicConfigurableObject() {
         }
     
         @Override
    -    public void injectManagementContext(ManagementContext managementContext) {
    +    public void setManagementContext(ManagementContext managementContext) {
    --- End diff --
    
    Breaks binary + source compatibility, but I guess it's fine as we've already have another
precedent for this release. Worth adding to the release notes.
    
    Out of curiosity, is this needed for OSGi injection, which library will be able to inject
the context here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message