brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Feature: entity monitoring disabl...
Date Tue, 24 Nov 2015 16:14:25 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1062#discussion_r45756261
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/AbstractMongoDBSshDriver.java
---
    @@ -115,7 +116,12 @@ public void customize() {
         @Override
         public boolean isRunning() {
             try {
    -            return MongoDBClientSupport.forServer((AbstractMongoDBServer) entity).ping();
    +            if (entity instanceof MongoDBServerImpl && !((MongoDBServerImpl)entity).clientAccessEnabled())
{
    --- End diff --
    
    Is there a good reason to single out `MongoDBServerImpl` over the lack of support for
replica sets or shards if client access is disabled? I'd prefer that it didn't. There's no
reason it can't support the clients, routers and config servers too. I believe that technically
the replica set and sharded entities could be written to handle such restrictive environments
(by SSHing to machines and executing scripts rather than connecting with `MongoDBClientSupport`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message