brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds WinRmTool interface
Date Tue, 24 Nov 2015 14:39:47 GMT
Github user bostko commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1045#issuecomment-159287775
  
    Very good start for putting alternative WinRm implementations!
    
    As part of this refactoring I want to remind you to review #950 .
    My opinion is that we have to have the basic `executeCommand(String)` signature instead
of `executeScript(String)`.
    If we want to execute scripts is supposed to be configurable e.g. error logging, exit
on first error. This requires extra work which shouldn't be mandatory.
    Interesting that `SshTool` has `executeCommands(List<String>...)` and `executeScript(List<String>,...)`
    
    Basically I think that we have to have only `executeCommand(String)` or `executeCommands(List<String>)`
in `WinRmTool` interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message